Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read/write timeseries section of inp #113

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Read/write timeseries section of inp #113

merged 3 commits into from
Dec 4, 2020

Conversation

jackieff
Copy link
Contributor

@jackieff jackieff commented Dec 3, 2020

#57 Addresses TIMESERIES section. Model object can now read timeseries section (direct data and file-pointers). replace_inp_section also works. Added a file-pointing timeseries into model_full_features_network.inp for testing.

aerispaha
aerispaha requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@aerispaha aerispaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rules, thanks @jackieff!

My only request is that we add an actual assertion in the test_get_set_timeseries unit test

swmmio/core.py Show resolved Hide resolved
swmmio/tests/test_model_elements.py Outdated Show resolved Hide resolved
@jackieff jackieff requested a review from aerispaha December 4, 2020 04:07
aerispaha
aerispaha approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@aerispaha aerispaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@aerispaha aerispaha added this to the v0.4.7 milestone Dec 4, 2020
@aerispaha aerispaha linked an issue Dec 4, 2020 that may be closed by this pull request
provide read/write interface to all INP sections #57
Open
57 tasks
@aerispaha aerispaha removed a link to an issue Dec 4, 2020
provide read/write interface to all INP sections #57
Open
57 tasks
@aerispaha aerispaha merged commit f344a8b into pyswmm:master Dec 4, 2020
@jackieff jackieff deleted the timeseries_functionality branch December 4, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerispaha aerispaha aerispaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jackieff @aerispaha