Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple writers race on windows #70

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

jabdoa2
Copy link
Contributor

@jabdoa2 jabdoa2 commented Dec 13, 2020

We found a race between two poll_writers which can happen in our test harness. I guess this will also happen on real windows machines. This will trigger the assert Write buffer should not be empty in _write_ready. Therefore, might have to backport it.

@Hedda
Copy link

Hedda commented Dec 14, 2020

@rob-smallshire Any plans for a quick bug-fix release? E.g. 0.5.2 or similar if using semantic versioning https://semver.org or just 0.6?

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Dec 14, 2020

We would like a 0.5.1 as well @rob-smallshire @zsquareplusc. Would that be possible?

@puddly
Copy link
Contributor

puddly commented Jan 8, 2021

I would also like to 👍 releasing 0.5.1. Serial writes just do not occur on Windows 10 with the 0.5 release. You have to either downgrade pyserial-asyncio to 0.4 or manually install the master branch via Git.

@Hedda
Copy link

Hedda commented Apr 26, 2021

@zsquareplusc @rob-smallshire @septatrix @wolfmanjm Can you please publish bug-fix release to resolve these Windows issues?

@hojo0590
Copy link

dear maintainers - what needs to be done in order for you to release a new version including this fix? do you want any other issues fixed before? or is this project abandoned (which would be really sad)?

@rob-smallshire
Copy link
Collaborator

@hojo0590 Only @zsquareplusc is in a position to make releases. I have and continue to merge fixes, but I cannot release to PyPI.

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Aug 24, 2021

If you need an additional maintainer I would be more than happy to help. I currently maintain a few pypi packages already (pinball related).

@Hedda
Copy link

Hedda commented Aug 24, 2021

Only @zsquareplusc is in a position to make releases. I have and continue to merge fixes, but I cannot release to PyPI.

@bufferoverflow please see all the requests for a new version PyPI release of pyserial-asyncio in #69 and #70

As you are on the pySerial-team, do you also have admin privileges to assign release permission to additional devs as maintainers?

https://pypi.org/project/pyserial-asyncio/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants