Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the get_files function skip excluded directories #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jianse
Copy link

@jianse jianse commented Sep 13, 2024

this may help #233

following is an simple benchmark output

bench

Copy link
Contributor

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks interesting.

I'm not a maintainer, but are you open to adding automated benchmarks to CI?

@jianse
Copy link
Author

jianse commented Oct 14, 2024

I add the benchmark at https://github.com/jianse/rust-embed/tree/benchmark . But it missing some example data to support it. see https://github.com/jianse/rust-embed/blob/0601a054c0d9971ff831e9919a4a78a34825c179/benches/walkdir_bench.rs#L8

after fix the example data problem. you can run cargo bench to get the benchmark result.

about the automation part. I am not familiar with it. so any help with be be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants