memory leak occurs when creating a new type

[zaxrok]

A memory leak occurs when this part with_service_schemas(service_class) is used.
This is a serious problem, so we need to take quick action.
And I found the code that caused a memory leak so I look forward to your efforts.

pyros-schemas/pyros_schemas/ros/schemagic.py

Line 101 in 9e3debe

MsgSchema = type(ros_msg_class.__name__ + 'Schema', (RosSchema,), members)

Please check

[asmodehn]

Oh I didnt check for leaks yet... Good to know, thanks. Which interpreter you use ? How did you launch that code ? What is the minimum code to reproduce the problem ( http://sscce.org ) ? On Feb 2, 2018 11:05, "Bcchoi" <[email protected]> wrote: A memory leak occurs when this part with_service_schemas(service_class) is used. This is a serious problem, so we need to take quick action. And I found the code that caused a memory leak so I look forward to your efforts. https://github.com/pyros-dev/pyros-schemas/blob/9e3debe4289e addb84562d0cdc9f431f8d929685/pyros_schemas/ros/schemagic.py#L101 Please check — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANgSNmCCB0GnTsVDrkPLYlWfTCCtwDRks5tQt4DgaJpZM4R28wi> .

[asmodehn]

We also need to think about automatic testing, to make sure we don't have the same issue in the future.

How would you design tests for memory leaks ? We need to cover as much code as possible and test that no leaks happen.

Ideally we should merge the leak tests in before the PR #9, to quickly prove there are leaks before (in master), but there are gone in PR branch.