Remove Add Batch Output from api #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrocumulus
added
the
api breaking change
- Removed inheritance for OutputPost / BatchOutputPost; merged all properties - Removed inheritance for their respective builders - Renamed all occurences of BatchOutput to Outputs - Added new properties to IOutputPost as per documentation - Implemented those properties in the AddOutput request - Removed old AddBatchOutputRequest and added AddOutputsRequest with a baseline for operation TODO: Unit tests are currently disabled New properties can not yet be set through the builders
Codecov Report
@@ Coverage Diff @@
## develop #78 +/- ##
========================================
Coverage 99.49% 99.50%
========================================
Files 120 116 -4
Lines 2188 2212 +24
Branches 140 144 +4
========================================
+ Hits 2177 2201 +24
Misses 4 4
Partials 7 7 |
Added new properties to OutputPostBuilder Rewritten all batch related unit tests Added more tests for all the new properties
Removed unnecessary analyses suppressions Fixed naming convention violations Tidied up the explicit / var usaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PVOutput removed their addbatchoutput.jsp entrypoint and made batching of outputs a donation only option within the (originally) single add output entrypoint.
We need to remove our AddBatchOutput method and request and we need to change the AddOutput to support multiple outputs in one request. Also update the documentation on our end, to make clear that this is a donation only feature.
See new documentation:
https://pvoutput.org/help/api_specification.html#batching-outputs
When done, this will close #75