Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostSystem request #32

Merged
merged 8 commits into from
Apr 25, 2020
Merged

Add PostSystem request #32

merged 8 commits into from
Apr 25, 2020

Conversation

pyrocumulus
Copy link
Owner

This enables modifying the system name and the definitions of it's extended data values.

Without builder
Without tests
@pyrocumulus pyrocumulus added the enhancement New feature or request label Apr 23, 2020
@pyrocumulus pyrocumulus linked an issue Apr 23, 2020 that may be closed by this pull request
@pyrocumulus pyrocumulus added this to the 0.7.1 milestone Apr 23, 2020
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #32 into develop will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #32      +/-   ##
===========================================
+ Coverage    93.06%   93.33%   +0.27%     
===========================================
  Files          109      112       +3     
  Lines         1903     1981      +78     
  Branches       122      133      +11     
===========================================
+ Hits          1771     1849      +78     
  Misses          98       98              
  Partials        34       34              

Added unit tests for correctly providing url arguments
Updated changelog
Also fixed some missing xmldoc references to which builders to use
Added test for the builder
Fixed partial match
How do does darn partial hits work!?
@pyrocumulus pyrocumulus reopened this Apr 25, 2020
@pyrocumulus pyrocumulus merged commit ab2d760 into develop Apr 25, 2020
@pyrocumulus pyrocumulus deleted the post-system-service branch April 25, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post System Service
1 participant