Add structured search methods to the Search service #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of details on the PVOutput side for the query text still hazy. Some queries do not return anything.
Codecov Report
@@ Coverage Diff @@
## develop #27 +/- ##
===========================================
+ Coverage 89.83% 90.61% +0.77%
===========================================
Files 109 109
Lines 1800 1928 +128
===========================================
+ Hits 1617 1747 +130
+ Misses 183 181 -2 |
… proved impossible. - Added new separate Search methods for each parameter.
pyrocumulus
changed the title
|
Because only specific terms can be combined in the query parameter, a builder solution does not fit here. I've rewritten the PR to make specific search methods per type of query. |
pyrocumulus
added a commit
that referenced
this pull request
Apr 3, 2020
Updated maintenance (in preparation of #27)
|
Implementation seems correct, however the PVOutput api has a couple of queries that do not work or work different as expected. https://forum.pvoutput.org/t/search-jsp-returning-blank-data-when-searching-for-size/2954 This PR is on hold until those issues are resolved. |
Also added html encoding to the * and + characters in some queries All structured search methods now have their own logging scope
Removed the util method for structured searches in the SearchService, wasn't that useful anymore
It's broken in the PVOutput api at the moment. And it has fairly limited use, considering this search can also be done by either postcode or size; and those queries do actually work. It might come back when it's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10 .