Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EastWest panel orientation #131

Merged
merged 2 commits into from
Jul 24, 2022
Merged

Add support for EastWest panel orientation #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0a2a8
Add support for EastWest panel orientation
pyrocumulus Jul 22, 2022
635cfe2
Update changelog to reflect change
pyrocumulus Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## Unreleased

### Fixed

- Added support for undocumented panel orientation 'EastWest' [#131](https://github.com/pyrocumulus/pvoutput.net/pull/131) - Contribution [CodeCasterNL](https://github.com/CodeCasterNL)

## [0.11.0] - 2022-05-05

### Changed
Expand Down
8 changes: 7 additions & 1 deletion src/PVOutput.Net/Enums/Orientation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ public enum Orientation
/// NorthWest
/// </summary>
[Description("NW")]
NorthWest = 7
NorthWest = 7,

/// <summary>
/// EastWest
/// </summary>
[Description("EW")]
EastWest = 8
}
}
2 changes: 1 addition & 1 deletion tests/PVOutput.Net.Tests/Modules/System/SystemServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public async Task SystemReader_OwnSystemWithoutSecondaryPanelResponse_CreatesCor
Assert.That(result.NumberOfInverters, Is.EqualTo(1));
Assert.That(result.InverterPower, Is.EqualTo(5500));
Assert.That(result.InverterBrand, Is.EqualTo("Fronius Primo 3.6-1"));
Assert.That(result.Orientation, Is.EqualTo(Orientation.East));
Assert.That(result.Orientation, Is.EqualTo(Orientation.EastWest));
Assert.That(result.ArrayTilt, Is.EqualTo(53.0m));
Assert.That(result.Shade, Is.EqualTo(Shade.None));
Assert.That(result.InstallDate, Is.Null);
Expand Down
2 changes: 1 addition & 1 deletion tests/PVOutput.Net.Tests/Modules/System/SystemSystemTestsData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public partial class SystemServiceTests

public const string SYSTEM_RESPONSE_SIMPLE = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,E,,No,,51.0,6.1,5;;";

public const string OWNSYSTEM_RESPONSE_WITHOUT_SECONDARYPANEL = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,E,53.0,No,,51.0,6.1,5,,,null,NaN;";
public const string OWNSYSTEM_RESPONSE_WITHOUT_SECONDARYPANEL = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,EW,53.0,No,,51.0,6.1,5,,,null,NaN;";

public const string SYSTEM_RESPONSE_EXTENDED = "Test System,4125,1234,15,275,JA Solar mono,1,5500,Fronius Primo 3.6-1,E,53.1,No,20160822,51.0,6.1,5,10,190,W,33.5;17.37,20.46,20.2,25.4,22.65,40.0;12,232,480,512;1;DC-1 Voltage,V,DC-2 Voltage,V,DC-DC Booster Temp,°C,DC-1 Power (2x13x290Wp),W;61,106,252,380,430,425,417,354,253,159,70,48,400,350,300,250,200,150,100,175,275,375,475,525";

Expand Down