Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up code analysis warnings #100

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Cleaning up code analysis warnings #100

merged 3 commits into from
Dec 15, 2021

Conversation

pyrocumulus
Copy link
Owner

Closes #97

@pyrocumulus pyrocumulus added enhancement New feature or request api breaking change This issue or pull request will result in a breaking change code quality Improves unit testing, code coverage and/or reduces dead code labels Nov 28, 2021
@pyrocumulus pyrocumulus added this to the 1.0.0 milestone Nov 28, 2021
@pyrocumulus pyrocumulus self-assigned this Nov 28, 2021
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #100 (3343378) into develop (5719005) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #100   +/-   ##
========================================
  Coverage    99.49%   99.49%           
========================================
  Files          120      120           
  Lines         2159     2176   +17     
  Branches       136      136           
========================================
+ Hits          2148     2165   +17     
  Misses           4        4           
  Partials         7        7           

@pyrocumulus pyrocumulus merged commit 2b36de7 into develop Dec 15, 2021
@pyrocumulus pyrocumulus deleted the code-cleanup branch December 15, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking change This issue or pull request will result in a breaking change code quality Improves unit testing, code coverage and/or reduces dead code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CA1716 naming violations
1 participant