Exclude seed handler from the PYRO_STACK #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neerajprad
reviewed
Oct 11, 2019
| super(_SeedMessenger, self).__enter__() | ||
|
|
||
| def __exit__(self, type, value, traceback): | ||
| set_rng_state(self.old_state) |
There was a problem hiding this comment.
+1 on restoring the previous state - this makes the behavior identical across backends.
3 tasks
This was referenced Oct 11, 2019
neerajprad
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seed handler is special in Pyro and Minipyro in that it affects state in the global rng seed, rather than in Pyro. Moreover we would like to use this handler globally, as is done in Numpyro. One thing that makes this difficult is that much of our code tests
if not PYRO_STACK: ...do shortcut.... This PR omits theSeedhandler from thePYRO_STACK, thus making it possible to use that handler globally while preserving old shortcuts.This PR also makes the seed handler restore previous state on exit, thereby providing compatibility with the numpyro backend.
For motivation, see https://github.com/pyro-ppl/numpyro/pull/396/files#r334110296