Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Paths for custom data #1241

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Conversation

GbotemiB
Copy link
Collaborator

@GbotemiB GbotemiB commented Dec 17, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

This PR address a few issues

  • Absolute path for data path (airport and ports)
  • Move Copy custom data
  • Re-position condition to avoid condition if custom data is preferred

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @GbotemiB :D
This PR looks a great nice have.
Since we are here, would you mind adding a release_note about the inclusion of custom data for airports?

This PR can be merged right after for me

@GbotemiB
Copy link
Collaborator Author

Thank you @davide-f for reviewing. I have addressed the release notes.

@davide-f davide-f force-pushed the fix-paths branch 2 times, most recently from d36786c to fdc14d3 Compare December 19, 2024 23:17
@davide-f davide-f merged commit ec37fe1 into pypsa-meets-earth:main Dec 20, 2024
6 checks passed
@davide-f
Copy link
Member

Merged :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants