pep621: don't fail on missing extra attribute paths

These paths should be considered, but not a hard fail when they don't exist. Otherwise calling project loaders dynamically would become unergonomic.
pyproject-nix · Nov 9, 2023 · d59144a · d59144a
1 parent 3c2590f
commit d59144a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/lib/pep621.nix b/lib/pep621.nix
@@ -4,7 +4,7 @@ let
   inherit (lib) isString filterAttrs fix;
 
   splitAttrPath = path: filter isString (split "\\." path);
-  getAttrPath = path: lib.getAttrFromPath (splitAttrPath path);
+  getAttrPath = path: lib.attrByPath (splitAttrPath path) { };
 
 in
 fix (self: {

diff --git a/lib/test_project.nix b/lib/test_project.nix
@@ -2,6 +2,7 @@
 , fixtures
 , renderers
 , mocks
+, lib
 , ...
 }:
 let
@@ -11,8 +12,24 @@ let
   getPkgs = set: pnames: map (pname: set.pkgs.${pname}) pnames;
 
 in
-{
+lib.fix (self: {
+
   loadPyproject = {
+    testPandasMissingExtrasAttrPaths = {
+      expr =
+        let
+          project = loadPyproject {
+            pyproject = fixtures."pandas.toml";
+            extrasAttrPaths = [ "noway" ];
+          };
+        in
+        renderers.buildPythonPackage {
+          inherit project;
+          python = mocks.cpythonLinux38;
+        };
+      inherit (self.loadPyproject.testPandas) expected;
+    };
+
     testPandas = {
       expr =
         let
@@ -218,4 +235,4 @@ in
       };
     };
   };
-}
+})