Skip to content

Commit

Permalink
build.checks: Run build checks for all supported Python versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@adisbladis
adisbladis committed Nov 23, 2024
1 parent a9ce23a commit d31c5e0
Show file tree
Hide file tree
Showing 2 changed files with 179 additions and 166 deletions.
343 changes: 178 additions & 165 deletions build/checks/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,44 +6,195 @@

let
inherit (pyproject-nix.build.lib) renderers;
inherit (lib) filter attrValues isDerivation;

python = pkgs.python312;
inherit (lib)
filterAttrs
listToAttrs
concatMap
mapAttrsToList
nameValuePair
attrNames
;

buildSystems = import ./build-systems.nix {
inherit lib;
};

# Inject your own packages on top with overrideScope
pythonSet =
(pkgs.callPackage pyproject-nix.build.packages {
inherit python;
}).overrideScope
buildSystems;
pythonInterpreters =
let
# Filter out Python pre-releases from testing
isPre = version: (pyproject-nix.lib.pep440.parseVersion version).pre != null;
in
filterAttrs (
n: drv: lib.hasPrefix "python3" n && n != "python3Minimal" && !isPre drv.version
) pkgs.pythonInterpreters;

testVenv = pythonSet.pythonPkgsHostHost.mkVirtualEnv "test-venv" {
build = [ ];
};
mkChecks =
python:
let
# Inject your own packages on top with overrideScope
pythonSet =
(pkgs.callPackage pyproject-nix.build.packages {
inherit python;
}).overrideScope
buildSystems;

# Test fixture
myapp = pyproject-nix.lib.project.loadPyproject {
projectRoot = ./fixtures/myapp;
};
testVenv = pythonSet.pythonPkgsHostHost.mkVirtualEnv "test-venv" {
build = [ ];
};

# Test fixture
myapp = pyproject-nix.lib.project.loadPyproject {
projectRoot = ./fixtures/myapp;
};

testEnviron = pyproject-nix.lib.pep508.mkEnviron python;

in

{
make-venv =
pkgs.runCommand "venv-run-build-test"
{
nativeBuildInputs = [ testVenv ];
}
''
pyproject-build --help > /dev/null
touch $out
'';

prebuilt-wheel = pythonSet.pythonPkgsHostHost.callPackage (
{
stdenv,
fetchurl,
pyprojectWheelHook,
}:
stdenv.mkDerivation {
pname = "arpeggio";
version = "2.0.2";

src = fetchurl {
url = "https://files.pythonhosted.org/packages/f7/4f/d28bf30a19d4649b40b501d531b44e73afada99044df100380fd9567e92f/Arpeggio-2.0.2-py2.py3-none-any.whl";
hash = "sha256-98iuT0BWqJ4CDCTHICrI3z4ryE5BZ0byCw2jW7HeAlA=";
};

nativeBuildInputs = [ pyprojectWheelHook ];
}
) { };

testEnviron = pyproject-nix.lib.pep508.mkEnviron python;
mkderivation =
let
testSet = pythonSet.pythonPkgsHostHost.overrideScope (
final: _prev: {
myapp = final.callPackage (
{
stdenv,
pyprojectHook,
resolveBuildSystem,
}:
stdenv.mkDerivation (
renderers.mkDerivation
{
project = myapp;
environ = testEnviron;
}
{
inherit pyprojectHook resolveBuildSystem;
}
)
) { };
}
);

venv = testSet.mkVirtualEnv "render-mkderivation-env" {
myapp = [
"toml" # Extra
"round" # PEP-735 dependency group
];
};
in
pkgs.runCommand "render-mkderivation-test" { nativeBuildInputs = [ venv ]; } ''
# Assert that extra was enabled
python -c "import tomli_w"
# Assert that dependency group was enabled
python -c "import wheel"
# Script from myapp
hello
touch $out
'';

mkderivation-editable =
let
testSet = pythonSet.pythonPkgsHostHost.overrideScope (
final: _prev: {
myapp = final.callPackage (
{
python,
stdenv,
pyprojectHook,
resolveBuildSystem,
pythonPkgsBuildHost,
}:
stdenv.mkDerivation (
renderers.mkDerivationEditable
{
project = myapp;
environ = testEnviron;
root = "$NIX_BUILD_TOP/src";
}
{
inherit
python
pyprojectHook
resolveBuildSystem
pythonPkgsBuildHost
;
}
)
) { };
}
);

venv = testSet.mkVirtualEnv "render-mkderivation-editable-env" {
myapp = [ ];
};

in
pkgs.runCommand "render-mkeditable" { nativeBuildInputs = [ venv ]; } ''
# Unpack sources into build
cp -r ${./fixtures/myapp}/* .
chmod +w -R src
hello | grep "Hello from myapp"
cat > src/myapp/__init__.py <<EOF
def hello() -> None:
print("Hello from editable!")
EOF
hello | grep "Hello from editable"
touch $out
'';
};

in

{
make-venv =
pkgs.runCommand "venv-run-build-test"
{
nativeBuildInputs = [ testVenv ];
}
''
pyproject-build --help > /dev/null
touch $out
'';
# Run checks for all python interpreters supported by nixpkgs except for pre-releases
listToAttrs (
concatMap (
pythonPrefix:
let
python = pythonInterpreters.${pythonPrefix};
checks = mkChecks python;
in
mapAttrsToList (name: check: nameValuePair "${pythonPrefix}-${name}" check) checks
) (attrNames pythonInterpreters)
)
// {
# Tests that don't need to run on every supported interpreter

make-venv-cross =
let
Expand All @@ -60,142 +211,4 @@ in
cffi = [ ];
};

prebuilt-wheel = pythonSet.pythonPkgsHostHost.callPackage (
{
stdenv,
fetchurl,
pyprojectWheelHook,
}:
stdenv.mkDerivation {
pname = "arpeggio";
version = "2.0.2";

src = fetchurl {
url = "https://files.pythonhosted.org/packages/f7/4f/d28bf30a19d4649b40b501d531b44e73afada99044df100380fd9567e92f/Arpeggio-2.0.2-py2.py3-none-any.whl";
hash = "sha256-98iuT0BWqJ4CDCTHICrI3z4ryE5BZ0byCw2jW7HeAlA=";
};

nativeBuildInputs = [ pyprojectWheelHook ];
}
) { };

full-set =
let
pythonSetDrvs = filter isDerivation (attrValues pythonSet.pythonPkgsHostHost);
hooks = attrValues pythonSet.pythonPkgsHostHost.hooks;
pythonDrvs = filter (
drv:
!lib.elem drv hooks
&& !lib.elem (drv.pname or drv.name) [
"pyproject-hook"
"python3"
"stdenv-linux"
"stdenv-darwin"
]
) pythonSetDrvs;

full-set-venv = pythonSet.pythonPkgsHostHost.mkVirtualEnv "test-venv" (
lib.listToAttrs (map (drv: lib.nameValuePair (drv.pname or drv.name) [ ]) pythonDrvs)
);
in
full-set-venv;

mkderivation =
let
testSet = pythonSet.pythonPkgsHostHost.overrideScope (
final: _prev: {
myapp = final.callPackage (
{
stdenv,
pyprojectHook,
resolveBuildSystem,
}:
stdenv.mkDerivation (
renderers.mkDerivation
{
project = myapp;
environ = testEnviron;
}
{
inherit pyprojectHook resolveBuildSystem;
}
)
) { };
}
);

venv = testSet.mkVirtualEnv "render-mkderivation-env" {
myapp = [
"toml" # Extra
"round" # PEP-735 dependency group
];
};
in
pkgs.runCommand "render-mkderivation-test" { nativeBuildInputs = [ venv ]; } ''
# Assert that extra was enabled
python -c "import tomli_w"
# Assert that dependency group was enabled
python -c "import wheel"
# Script from myapp
hello
touch $out
'';

mkderivation-editable =
let
testSet = pythonSet.pythonPkgsHostHost.overrideScope (
final: _prev: {
myapp = final.callPackage (
{
python,
stdenv,
pyprojectHook,
resolveBuildSystem,
pythonPkgsBuildHost,
}:
stdenv.mkDerivation (
renderers.mkDerivationEditable
{
project = myapp;
environ = testEnviron;
root = "$NIX_BUILD_TOP/src";
}
{
inherit
python
pyprojectHook
resolveBuildSystem
pythonPkgsBuildHost
;
}
)
) { };
}
);

venv = testSet.mkVirtualEnv "render-mkderivation-editable-env" {
myapp = [ ];
};

in
pkgs.runCommand "render-mkeditable" { nativeBuildInputs = [ venv ]; } ''
# Unpack sources into build
cp -r ${./fixtures/myapp}/* .
chmod +w -R src
hello | grep "Hello from myapp"
cat > src/myapp/__init__.py <<EOF
def hello() -> None:
print("Hello from editable!")
EOF
hello | grep "Hello from editable"
touch $out
'';

}
2 changes: 1 addition & 1 deletion build/checks/fixtures/myapp/pyproject.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "myapp"
version = "0.1.0"
description = "Add your description here"
readme = "README.md"
requires-python = ">=3.12"
requires-python = ">=3.9"
dependencies = [
"zipp"
]
Expand Down

0 comments on commit d31c5e0

Please sign in to comment.