Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing constructor-methods from staticmethods to classmethods #848

Closed
wants to merge 5 commits into from

Conversation

nmaxwell
Copy link

changes use of staticmethods to classmethods in constructor-methods in Transformer and CRS. I left from_cf in CRS, as there is some logic in there on whether to return a CRS, a GeographicCRS, a DerivedGeographicCRS, or a CompoundCRS. It may require some rethinking on how handle that properly with classmethods.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #848 (7fa6dd7) into master (1117367) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7fa6dd7 differs from pull request most recent head 7be584c. Consider uploading reports for the commit 7be584c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          21       21           
  Lines        1672     1672           
=======================================
  Hits         1592     1592           
  Misses         80       80           
Impacted Files Coverage Δ
pyproj/crs/crs.py 97.47% <100.00%> (ø)
pyproj/transformer.py 95.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1117367...7be584c. Read the comment docs.

@snowman2
Copy link
Member

Thanks for taking a stab at this 👍 . The issue has been addressed by #902.

@snowman2 snowman2 closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRS classmethods changed to staticmethods
2 participants