Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use proj_create_crs_to_crs_from_pj for creating transformer PJ* #800

Closed
wants to merge 1 commit into from

Conversation

snowman2
Copy link
Member

Needed for #754

Attempted this in the past and had to revert (ref) due to instability in #412.

@cgohlke would you mind testing this with Windows to see if it works or if we should wait on this change?

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #800 (6285edd) into master (8a19f39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          21       21           
  Lines        1606     1606           
=======================================
  Hits         1527     1527           
  Misses         79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a19f39...6285edd. Read the comment docs.

@snowman2
Copy link
Member Author

snowman2 commented Mar 20, 2021

Have an alternative in #803 that should be stable as it is essentially what is in PROJ now. However, if this PR worked, it would be preferred because it reduces the need to re-create additional PJ* objects. Due to the instability introduced in the past, I am hesitant to proceed with this.

@snowman2 snowman2 closed this Mar 20, 2021
@snowman2 snowman2 deleted the transform branch April 3, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant