Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parallel omp cython code & parallel CICD matrix items #384

Merged
merged 4 commits into from
Aug 5, 2019

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Aug 5, 2019

Currently not possible. Only one thread can use one PJ* at a time. https://github.com/OSGeo/PROJ/blob/f567ee4b8739505716cbb000093d78678a97b170/src/iso19111/c_api.cpp#L338

It was unstable. See #380

@snowman2 snowman2 changed the title remove parallel omp cython code & parellel CICD matrix items remove parallel omp cython code & parallel CICD matrix items Aug 5, 2019
@snowman2 snowman2 merged commit c38a5fd into pyproj4:master Aug 5, 2019
@djhoese
Copy link
Contributor

djhoese commented Aug 27, 2019

Could you explain why you removed the nogil as part of this PR? Doesn't this mean that if I use pyproj in one thread that I'm now stuck in all other threads until pyproj is finished? I understand only using one PJ* at a time, but I think removing the nogil makes it so that nothing can be done in parallel while pyproj is working.

@snowman2
Copy link
Member Author

snowman2 commented Aug 27, 2019

It was out of an overabundance of caution. I wanted to make sure there was a clear understanding of how/when things should be used. Future plans to release GIL in #386

@snowman2
Copy link
Member Author

Also, the gil was never released in any of the pyproj code to date, so it will be new once added.

@snowman2 snowman2 deleted the remove_parallel branch September 2, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants