Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preparations for musllinux #9982

Merged
merged 7 commits into from
Sep 19, 2021
Merged

preparations for musllinux #9982

merged 7 commits into from
Sep 19, 2021

Conversation

liath
Copy link
Contributor

@liath liath commented Aug 31, 2021

PEP 656 is accepted! Let's get these wheels... rollin 😎

@liath liath mentioned this pull request Aug 31, 2021
Merged
4 tasks
h-vetinari
h-vetinari reviewed Sep 5, 2021
View reviewed changes
Copy link

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvement suggestions

warehouse/forklift/legacy.py Outdated Show resolved Hide resolved
warehouse/forklift/legacy.py Show resolved Hide resolved
@uranusjr
Copy link
Contributor

Gentle ping on this. auditwheel just released PEP 656 support and I think this is the last mile toward pip install-ing a musllinux wheel (IIRC pip already added support in the last release via packaging upgrade).

@liath
Copy link
Contributor Author

liath commented Sep 18, 2021

One sec, I throw in @h-vetinari's recs

@liath
Copy link
Contributor Author

liath commented Sep 18, 2021

Done! Any other thoughts?

alex
alex reviewed Sep 18, 2021
View reviewed changes
warehouse/forklift/legacy.py Outdated Show resolved Hide resolved
@alex
Copy link
Member

alex commented Sep 18, 2021

One suggestion from me, otherwise lgtm!

alex
alex approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to merge this myself, but it LGTM.

@alex
Copy link
Member

alex commented Sep 18, 2021

Oh, can you rebase this on main?

@mayeut mayeut mentioned this pull request Sep 18, 2021
Merged
6 tasks
@dstufft dstufft merged commit 30a6733 into pypi:main Sep 19, 2021
@liath liath deleted the musllinux branch September 19, 2021 01:16
@kumaraditya303 kumaraditya303 mentioned this pull request Sep 19, 2021
Closed
@di
Copy link
Member

di commented Sep 20, 2021

We need to update documentation in some places to include musllinux, e.g. https://packaging.python.org/guides/distributing-packages-using-setuptools/?highlight=manylinux#:~:text=PyPI%20currently%20supports%20uploads%20of%20platform%20wheels%20for%20Windows%2C%20macOS%2C%20and%20the%20multi-distro%20manylinux*%20ABI.

@Budgiebrain994 Budgiebrain994 mentioned this pull request Oct 12, 2021
Closed
domdfcoding pushed a commit to domdfcoding/warehouse that referenced this pull request Jun 7, 2022
@liath @domdfcoding
Add support for musllinux (pypi#9982)
c3694a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@messense messense messense left review comments

@ewjoachim ewjoachim ewjoachim left review comments

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@liath @uranusjr @alex @di @ewjoachim @messense @h-vetinari @dstufft