Add disallow deletion AdminFlag #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing upload: |
|
@di This PR is ready to review. |
|
@calvin Thank you for this PR! Would you mind fixing the merge conflict and then say here when you've done that, and I'll try to find some reviewers to help move this along? Thanks! |
calvin
force-pushed
the
issue-3218-halt-admin-flag
branch
from
07600e2 to
1246ab2
Compare
|
@brainwane resolved conflicts. |
ewdurbin
requested changes
Sep 9, 2019
di
reviewed
Sep 9, 2019
calvin
force-pushed
the
issue-3218-halt-admin-flag
branch
from
1246ab2 to
0595da3
Compare
|
that was a really solid suggestion @di! |
ewdurbin
approved these changes
Sep 11, 2019
calvin
force-pushed
the
issue-3218-halt-admin-flag
branch
from
8f0ff1d to
d20dda2
Compare
|
Thank you @calvin! |
woodruffw
pushed a commit
to trail-of-forks/warehouse
that referenced
this pull request
Sep 16, 2019
* Add AdminFlagValue * Add disallow deletion AdminFlag See pypi#3218 * Add disallow new upload AdminFlag * Convert `AdminFlagValue` to enum
|
@calvin I just want to note that this was great for a first PR not just in this repo but in PyPA as a whole. Thank you! If you're interested in helping more, we would welcome it, and I could suggest a couple things if you like! |
|
@brainwane I do want to make more contributions. Please tell me more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new AdminFlags which prevent projects/release from deletion or new uploads when enabled.
Closes #3218