Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users about the consequences of deleting a project #6319

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Warn users about the consequences of deleting a project #6319

merged 5 commits into from
Jul 31, 2019

Conversation

di
Copy link
Member

@di di commented Jul 30, 2019

Fixes #6318.

Screen Shot 2019-07-30 at 12 01 37 PM

@brettcannon
Copy link
Contributor

What does "with 1 release" mean? Is the latest release taken out but the files for all other releases left behind? (Basically I'm wondering if project deletion leads to a situation as bad as left-pad or just more of an index deletion than a complete nuking of the project).

@di
Copy link
Member Author

di commented Jul 30, 2019

The "with N release(s)` line is already present, it links to all the existing releases (and the number changed depending on the number of releases).

From a user's perspective, project deletion deletes everything: the project, all releases, all files.

Behind the scenes: we delete everything except the actual distribution file in our storage bucket, but the only way a user would be able to continue installing a deleted distribution would be to have the URL to that file and do pip install https://files.pythonhosted.org/../............. We also maintain a reference to what distributions once existed, which allows us to continue preventing filename reuse.

@nlhkabu
Copy link
Contributor

nlhkabu commented Jul 31, 2019

Updated as discussed @di

Screenshot from 2019-07-31 07-24-28

@di di merged commit 3fe5524 into master Jul 31, 2019
@di di deleted the fix/6318 branch July 31, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn maintainers that deleting a project allows the name to be reclaimed
3 participants