Correct normalization of Dynamic field names #16122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This led to the incorrect string being sent to the DB for the Dynamic ENUM when it was any of the following: `Home-Page`, `Download-Url`, `Author-Email`, `Maintainer-Email`, or `Project-Url`. This PR sets the strings in the Enum to be all `title()`ified and renames any existing values.
di
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15631 introduced normalization of field names set in
Dynamicto bestr.title()ified, but did not update the ENUM used:https://github.com/pypi/warehouse/pull/15631/files#diff-bffd49e4f943217b54b4cfcf5835737bec7a145360bd1dc2ec1541d2dcafad16R717
This led to the incorrect string being sent to the DB for the Dynamic ENUM when it was any of the following:
Home-Page,Download-Url,Author-Email,Maintainer-Email, orProject-Url.This PR sets the strings in the Enum to be all
title()ified and renames any existing values.Closes #16120