Use orjson for our json renderer #11675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our pyramid renderer from using the stdlib
json
module, to usingorjson
instead.I ran benchmarks testing the speed of
dumps
on the JSON version of/simple/
from live PyPI, and I got these results:This should make us something like 6x faster on serializing our json endpoints according to the above benchmarks.
The one gotcha with using
orjson
that makes it not a drop in replacement forjson
is that instead of returning astr
it returnsbytes
. This isn't a big deal for us as Pyramid's render system supports both, and will just encodestr
results anyways into bytes.