Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind "PositionWarning" function to CSILoaded event #10205

Merged
merged 1 commit into from
Oct 18, 2021
Merged

bind "PositionWarning" function to CSILoaded event #10205

merged 1 commit into from
Oct 18, 2021

Conversation

ewdurbin
Copy link
Member

proposed fix for #10199

@pradyunsg
Copy link
Contributor

Would it make sense to remove the setTimeout(PositionWarning) earlier in the file or, perhaps, to replace that with this instead?

@ewdurbin
Copy link
Member Author

@pradyunsg I'm not positive we can remove it since the js-stick-to-top class is used by some other warning banners (for unsupported browsers and testpypi).

@ewdurbin
Copy link
Member Author

yeah, confirmed that with that removed you end up in some goofy situations sometimes:
Screen Shot 2021-10-18 at 3 06 28 PM

@ewdurbin ewdurbin merged commit 737f893 into main Oct 18, 2021
@ewdurbin ewdurbin deleted the fix_banner_overlap branch October 18, 2021 19:50
domdfcoding pushed a commit to domdfcoding/warehouse that referenced this pull request Jun 7, 2022
@ewdurbin @domdfcoding
bind "PositionWarning" function to CSILoaded event (pypi#10205)
455b5c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewdurbin @pradyunsg