Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect additional vulnerability data, surface in JSON API #10197

Merged
merged 5 commits into from
Oct 19, 2021
Merged

Conversation

di
Copy link
Member

@di di commented Oct 15, 2021

This PR updates the vulnerability endpoint to collect additional fields from the vulnerability report, and also surfaces the vulnerabilities for a given release in the JSON API.

Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@di di force-pushed the add-vulns-to-api branch from 94a9a63 to a58e924 Compare October 19, 2021 17:36
@di di requested a review from ewdurbin October 19, 2021 17:47
Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some information to the help page on PyPI.org for folks to understand where this information comes from is probably a good idea.

Some users may understand this as coming from maintainers?

Some maintainers may be surprised/confused to see this published via our API without their involvement?

@di di merged commit eaa6539 into main Oct 19, 2021
@di di deleted the add-vulns-to-api branch October 19, 2021 20:27
domdfcoding pushed a commit to domdfcoding/warehouse that referenced this pull request Jun 7, 2022
* Collect additional data from vulnerability reports

* Surface vulnerabilities in JSON API

* Address code review

* Add help section

* Update translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants