Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uv parser #162

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Add uv parser #162

merged 4 commits into from
Apr 22, 2024

Conversation

samypr100
Copy link
Contributor

Hi 👋

uv recently added support to linehaul in astral-sh/uv#2493 to match what pip does as part of astral-sh/uv#1958 .

This PR aims to add support to uv user agents starting with release 0.1.22.

The implementation here in nature matches what pip does, including adding tests and fixtures for uv.

Closes astral-sh/uv#2568

@samypr100 samypr100 marked this pull request as ready for review March 25, 2024 16:35
@samypr100
Copy link
Contributor Author

samypr100 commented Mar 25, 2024

Since I registered a new parser, should I also bump the project version?

[project]
name = "linehaul"
-version = "1.0.1"
+version = "1.0.2"

@di
Copy link
Member

di commented Mar 25, 2024

Yes, because this gets published on PyPI: https://pypi.org/project/linehaul/

@samypr100
Copy link
Contributor Author

Yes, because this gets published on PyPI: https://pypi.org/project/linehaul/

Done in f639768

@di
Copy link
Member

di commented Mar 25, 2024

This looks ok to me, @ewdurbin wanna review?

@di di requested a review from ewdurbin March 25, 2024 18:38
@di
Copy link
Member

di commented Mar 25, 2024

I'd like to get #163 merged first so we have a bit more visibility into any errors we might get.

@samypr100
Copy link
Contributor Author

Hi @di

It seems #163 was merged; I was wondering if you'd have time to take a peek at this again.
It would be great to start seeing uv statistics coming in 🤞

Thanks!

@di di merged commit b10850c into pypi:main Apr 22, 2024
1 check passed
@samypr100 samypr100 deleted the uv-parser branch April 22, 2024 16:07
@samypr100
Copy link
Contributor Author

Thanks for the merge @di @ewdurbin

Does the cloud function gets updated automatically with what's on main or would it happen after the 1.0.2 release?

@di
Copy link
Member

di commented Apr 23, 2024

It gets deployed on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add uv parser to linehaul
3 participants