Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the Setup GUI #1879

Merged
merged 19 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions doc/api/pypeit.scripts.setup_gui.rst

This file was deleted.

5 changes: 4 additions & 1 deletion doc/releases/1.17.2dev.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Functionality/Performance Improvements and Additions
and `spat_flexure_vrange`, were added to control the detection of the slit edges
(used to compute the flexure) and the stretching of the image in the QA plot,
respectively.
- Setup GUI allows resizing panels when viewing pypeit files.
- Setup GUI allows selecting which detector to view when viewing raw data.

Instrument-specific Updates
---------------------------
Expand All @@ -30,7 +32,7 @@ Instrument-specific Updates
Script Changes
--------------


- `pypeit_setup_gui` script has been removed. The Setup GUI can be started with `pypeit_setup -G`.

Datamodel Changes
-----------------
Expand All @@ -50,3 +52,4 @@ Bug Fixes
the spectrum is extracted even when `pixelflat_model` does not exist.
- The variance cube previously had a cubic term, and this has been changed
to a quadratic term. This has been cross-checked with simple subpixel calculations.
- Fix Setup GUI sizing issues on MacOS.
26 changes: 5 additions & 21 deletions pypeit/scripts/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ def main(args):
from pypeit.pypeitsetup import PypeItSetup
from pypeit.calibrations import Calibrations

# Set the verbosity, and create a logfile if verbosity == 2
msgs.set_logfile_and_verbosity('setup', args.verbosity)

if args.spectrograph is None:
if args.gui is False:
raise IOError('spectrograph is a required argument. Use the -s, --spectrograph '
Expand All @@ -96,24 +93,11 @@ def main(args):
'on how to add a new instrument.')

if args.gui:
from pypeit.scripts.setup_gui import SetupGUI
# Build up arguments to the GUI
setup_gui_argv = ["-e", args.extension]
if args.spectrograph is not None:
setup_gui_argv += ["-s", args.spectrograph]

# Pass root but only if there's a spectrograph, because
# root has a default value but can't be acted upon by the GUI
# without a spectrograph.
if isinstance(args.root,list):
root_args = args.root
else:
# If the root argument is a single string, convert it to a list.
# This can happen when the default for --root is used
root_args = [args.root]
setup_gui_argv += ["-r"] + root_args
gui_args = SetupGUI.parse_args(setup_gui_argv)
SetupGUI.main(gui_args)
# Start the GUI
from pypeit.setup_gui.controller import start_gui
start_gui(args)
else:
msgs.set_logfile_and_verbosity("setup", args.verbosity)

# Initialize PypeItSetup based on the arguments
ps = PypeItSetup.from_file_root(args.root, args.spectrograph, extension=args.extension)
Expand Down
58 changes: 0 additions & 58 deletions pypeit/scripts/setup_gui.py

This file was deleted.

Loading
Loading