Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks for bad wavetilts calibration #1873

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Added checks for bad wavetilts calibration #1873

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8c529d
fix it
debora-pe Nov 16, 2024
f125d02
small change
debora-pe Nov 16, 2024
5c3db12
Merge branch 'develop' into fix_tilts
kbwestfall Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pypeit/wavetilts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,13 @@ def run(self, doqa=True, debug=False, show=False):
self.spat_order[slit_idx], self.spec_order[slit_idx],
slit_idx,
doqa=doqa, show_QA=show)
# Flag slits with high number of rejected pixels (>95%)
# TODO: Is 95% the right threshold?
_gpm = self.all_fit_dict[slit_idx]['pypeitFit'].bool_gpm
if np.sum(np.logical_not(_gpm)) > 0.95 * _gpm.size:
msgs.warn(f'Large number of pixels rejected in the fit. This slit/order will not be reduced!')
self.slits.mask[slit_idx] = self.slits.bitmask.turn_on(self.slits.mask[slit_idx], 'BADTILTCALIB')
continue
self.coeffs[:self.spec_order[slit_idx]+1,:self.spat_order[slit_idx]+1,slit_idx] = coeff_out

# TODO: Need a way to assess the success of fit_tilts and
Expand All @@ -807,6 +814,12 @@ def run(self, doqa=True, debug=False, show=False):
# images, trace images, and pixelflats etc.
self.tilts = tracewave.fit2tilts(self.slitmask_science.shape, coeff_out,
self.par['func2d'])
# Check that the tilts image has values that span a reasonable range
# TODO: Is this the right threshold?
if np.nanmax(self.tilts) - np.nanmin(self.tilts) < 0.8:
msgs.warn('Tilts image fit not good. This slit/order will not be reduced!')
self.slits.mask[slit_idx] = self.slits.bitmask.turn_on(self.slits.mask[slit_idx], 'BADTILTCALIB')
continue
# Save to final image
thismask_science = self.slitmask_science == slit_spat
self.final_tilts[thismask_science] = self.tilts[thismask_science]
Expand Down
Loading