Skip to content

Commit

Permalink
Merge pull request #1721 from pypeit/platescale_hotfix
Browse files Browse the repository at this point in the history
Hotfix: Platescale binning correction
  • Loading branch information
kbwestfall authored Nov 8, 2023
2 parents ec1584d + bd6c142 commit 058bbfb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions doc/releases/1.14.1dev.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,8 @@ Bug Fixes
the sigdetect parameter was a list of all orders, instead of a single value.
- Fixed a bug with the GUI ``pypeit_skysub_regions``. Previously, the calib header
information was not included, and this led to a calibration error.
- Corrected the binning scaling for BOXCAR_RADIUS in the object-finding algorithm.
Previously, the platescale was multiplied by the *spectral* binning and not the
*spatial* binning.


4 changes: 2 additions & 2 deletions pypeit/find_objects.py
Original file line number Diff line number Diff line change
Expand Up @@ -694,8 +694,8 @@ def get_platescale(self, slitord_id=None):
:obj:`float`: plate scale in binned pixels
"""
bin_spec, bin_spat = parse.parse_binning(self.binning)
return self.sciImg.detector.platescale * bin_spec
_, bin_spat = parse.parse_binning(self.binning)
return self.sciImg.detector.platescale * bin_spat

def find_objects_pypeline(self, image, ivar, std_trace=None,
manual_extract_dict=None,
Expand Down

0 comments on commit 058bbfb

Please sign in to comment.