Fix crop box parameter order in README.md #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order should be (left, bottom, right, top) as in https://github.com/pypdfium2-team/pypdfium2/blob/604c582cafd41e5d8904145076d738558bf1c445/src/pypdfium2/_cli/render.py#LL104C38-L104C62 and https://github.com/pypdfium2-team/pypdfium2/blob/604c582cafd41e5d8904145076d738558bf1c445/src/pypdfium2/_helpers/page.py#L419
|
Uh, same problem as #174. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order should be (left, bottom, right, top) as in
pypdfium2/src/pypdfium2/_cli/render.py
Lines 99 to 104 in 604c582
and
pypdfium2/src/pypdfium2/_helpers/page.py
Lines 418 to 420 in 604c582