Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start a full API and test suite rewrite #111

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Start a full API and test suite rewrite #111

merged 2 commits into from
Jun 7, 2022

Conversation

mara004
Copy link
Member

@mara004 mara004 commented May 28, 2022 •
edited
Loading

Experimental change.

Tasks

  • Add remaining tests
    • CLI
    • Page Renderer: Annotations, Forms
  • Improve global namespace
  • Think of better names for some parts
  • Extend API (e. g. page labels, page insertion, document metadata, viewer preferences ...) → Perhaps better in separate PRs

Done (mostly)

  • New API and documentation
  • Changelog
  • Tests for version, renderer, opener, saver, text extractor, link extractor, text inserter, pdf boxes, and toc
  • Setup and version improvements

Post-merge tasks

@mara004 mara004 force-pushed the rewrite branch 30 times, most recently from 2d7ee8c to a8d4839 Compare May 30, 2022 21:03
mara004
mara004 commented Jun 5, 2022
View reviewed changes
tests/test_module.py Outdated Show resolved Hide resolved
@mara004

This comment was marked as outdated.

Sign in to view
mara004
mara004 commented Jun 5, 2022
View reviewed changes
src/pypdfium2/_cli/toc.py Outdated Show resolved Hide resolved
@mara004 mara004 force-pushed the rewrite branch 2 times, most recently from cde8071 to aba8038 Compare June 6, 2022 09:11
@mara004 mara004 mentioned this pull request Jun 6, 2022
Merged
@mara004 mara004 force-pushed the rewrite branch 2 times, most recently from 9b39843 to f1d1b0f Compare June 6, 2022 09:34
@mara004 mara004 marked this pull request as ready for review June 7, 2022 19:50
@mara004
Copy link
Member Author

mara004 commented Jun 7, 2022 •
edited
Loading

I think this is finally ready for merging. The few remaining tasks can be done in main now.

@mara004 mara004 merged commit 997acb0 into main Jun 7, 2022
@mara004 mara004 deleted the rewrite branch June 7, 2022 19:57
@frgfm
Copy link

frgfm commented Jun 14, 2022

In case someone would like to review or beta-test this change: @MartinThoma @frgfm @adam-huganir @mkroutikov

Sorry @mara004, I was away for some time and wasn't able to help in time :/

@mara004
Copy link
Member Author

mara004 commented Jun 15, 2022

No problem :) In the end, this PR got such a chaotic mix of stylistic and functional changes that it might have been a bit too hard to overview for an external reviewer anyway.
In case have any questions or concerns about the new API, please let me know.

@frgfm
Copy link

frgfm commented Jun 15, 2022

Haha, I'm sure you handled it alright!
I'll try to help in the future, feel free to ping me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mara004 @frgfm