Skip to content

Commit

Permalink
conda/recipes: do not wrap env vars in quotes after all
Browse files Browse the repository at this point in the history
conda produces something like this
```
The environment variable 'PDFIUM_PLATFORM' is being passed through with
value '"prepared!system:6150"'
```
So seemingly the quotes are not stripped yet when this print is made.
The result was still correct, so probably they're still stripped
somewhere at some point, but it seems we might be safer off not adding
them in the first place after all.
  • Loading branch information
mara004 committed Nov 28, 2023
1 parent f3cc2dd commit acd1719
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion conda/bundle/recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ build:
entry_points:
- pypdfium2 = pypdfium2.__main__:cli_main
script_env:
- PDFIUM_PLATFORM="prepared!{{ pl_spec }}"
# NOTE conda neither needs nor likes env values being wrapped in quotes
- PDFIUM_PLATFORM=prepared!{{ pl_spec }}
script:
- {{ PYTHON }} conda/prepare_script.py
- {{ PYTHON }} -m pip install . -v --no-deps --no-build-isolation
Expand Down
2 changes: 1 addition & 1 deletion conda/raw/recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ build:
noarch: python
script_env:
- PYPDFIUM_MODULES=raw
- PDFIUM_PLATFORM="prepared!system:{{ pdfium_short }}"
- PDFIUM_PLATFORM=prepared!system:{{ pdfium_short }}
script:
- {{ PYTHON }} conda/prepare_script.py
- {{ PYTHON }} -m pip install . -v --no-deps --no-build-isolation
Expand Down

0 comments on commit acd1719

Please sign in to comment.