Apply more ruff rules #633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
- Coverage 71.18% 70.90% -0.28%
==========================================
Files 14 14
Lines 1093 1093
==========================================
- Hits 778 775 -3
- Misses 315 318 +3 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos
force-pushed
the
PERF
branch
from
fdff091
to
a2bf5b9
Compare
DimitriPapadopoulos
changed the title
|
I'm not seeing any changes to |
DimitriPapadopoulos
force-pushed
the
PERF
branch
from
e52494a
to
795d5df
Compare
|
May I ask what prompted this change? |
DimitriPapadopoulos
force-pushed
the
PERF
branch
from
9c9fa29
to
531756f
Compare
|
I just tried to apply some rules that raised a few valid issues in other projects. |
DimitriPapadopoulos
force-pushed
the
PERF
branch
2 times, most recently
from
59869f3
to
a2c0acc
Compare
PERF401 Use a list comprehension to create a transformed list
PIE810 Call `endswith` once with a `tuple`
PLC0208 Use a sequence type instead of a `set` when iterating over values
TCH003 Move standard library import into a type-checking block
FLY002 Consider f-string instead of string join
DimitriPapadopoulos
force-pushed
the
PERF
branch
from
a2c0acc
to
c95b95b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.