Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the RECORD file as CSV #281

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Write the RECORD file as CSV #281

merged 1 commit into from
Feb 10, 2019

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Jan 2, 2019

No description provided.

@pfmoore
Copy link
Member Author

pfmoore commented Jan 2, 2019

Some tests fail on Windows, but the same tests seem to fail on master as well, so I'm assuming that's expected. No CI for Windows?

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #281 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   59.42%   59.71%   +0.29%     
==========================================
  Files          12       12              
  Lines         828      834       +6     
==========================================
+ Hits          492      498       +6     
  Misses        336      336
Impacted Files Coverage Δ
wheel/wheelfile.py 100% <100%> (ø) ⬆️
wheel/util.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd00904...1083369. Read the comment docs.

@agronholm
Copy link
Contributor

Some tests fail on Windows, but the same tests seem to fail on master as well, so I'm assuming that's expected. No CI for Windows?

Azure Pipelines is the only reasonable way we could have a Windows CI. I will look into that when time permits.

@agronholm agronholm merged commit 64e089f into pypa:master Feb 10, 2019
@agronholm
Copy link
Contributor

Thank you. I had actually implemented this fix on my own too but was stuck making the tests pass on Python 2. This version was somewhat simpler than mine.

agronholm added a commit that referenced this pull request Feb 10, 2019
@agronholm
Copy link
Contributor

Azure Pipelines is the only reasonable way we could have a Windows CI. I will look into that when time permits.

Actually, I forgot about this: https://blog.travis-ci.com/2018-10-11-windows-early-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants