Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHEEL metadata uses CRLF line endings Windows #378

Closed
sputt opened this issue Sep 25, 2020 · 0 comments · Fixed by #383
Closed

WHEEL metadata uses CRLF line endings Windows #378

sputt opened this issue Sep 25, 2020 · 0 comments · Fixed by #383

Comments

@sputt
Copy link

sputt commented Sep 25, 2020

Building universal wheels should produce identical wheels on all platforms We need to use LF only line endings on Windows.

In bdist_wheel.py

        wheelfile_path = os.path.join(wheelfile_base, 'WHEEL')
        logger.info('creating %s', wheelfile_path)
        with open(wheelfile_path, 'w') as f:
            Generator(f, maxheaderlen=0).flatten(msg)

Proposed Fix

This should use a BytesGenerator on Python 3 and a Generator on Python 2. The open should occur with 'wb' on Python 3 and optionally 'wbN' on Python 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant