Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update run_with_catch log flushing #2806

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

neilramsay
Copy link
Contributor

run_with_catch is flushing the Python standard library logger prior to any traces are printed.

It appears the function logger.shutdown() does not work. Instead each logger handler stream should be flushed individually.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

run_with_catch is flushing the Python standard
library logger prior to any traces are printed.

It appears the function logger.shutdown() does not work.
Instead each logger handler stream should be flushed individually.
@gaborbernat gaborbernat merged commit d619967 into pypa:main Nov 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants