add test

Signed-off-by: Bernat Gabor <[email protected]>
pypa · Feb 26, 2020 · 8f3d8d2 · 8f3d8d2
1 parent 95fcb34
commit 8f3d8d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/virtualenv/seed/via_app_data/pip_install/base.py b/src/virtualenv/seed/via_app_data/pip_install/base.py
@@ -133,7 +133,7 @@ def _create_console_entry_point(self, name, value, to_folder, version_info):
         result = []
         maker = ScriptMaker(None, str(to_folder))
         maker.clobber = True  # overwrite
-        maker.variants = {""}
+        maker.variants = {""}  # set within patch_distlib_correct_variants
         maker.set_mode = True  # ensure they are executable
         # calling private until https://bitbucket.org/pypa/distlib/issues/135/expose-_enquote_executable-as-public
         maker.executable = _enquote_executable(str(self._creator.exe))

diff --git a/tests/unit/seed/test_boostrap_link_via_app_data.py b/tests/unit/seed/test_boostrap_link_via_app_data.py
@@ -21,7 +21,7 @@ def test_base_bootstrap_link_via_app_data(tmp_path, coverage_env, current_fastes
     current = PythonInfo.current_system()
     bundle_ver = BUNDLE_SUPPORT[current.version_release_str]
     create_cmd = [
-        ensure_text(str(tmp_path / "env")),
+        ensure_text(str(tmp_path / "en v")),  # space in the name to ensure generated scripts work when path has space
         "--seeder",
         "app-data",
         "--extra-search-dir",
@@ -64,9 +64,7 @@ def test_base_bootstrap_link_via_app_data(tmp_path, coverage_env, current_fastes
         assert not process.returncode
 
     remove_cmd = [
-        str(result.creator.exe),
-        "-m",
-        "pip",
+        str(result.creator.script("pip")),
         "--verbose",
         "--disable-pip-version-check",
         "uninstall",