Avoid showing new windows on Windows

Signed-off-by: Bernat Gabor <[email protected]>
pypa · Aug 24, 2020 · 411d28f · 411d28f
1 parent 6c098d8
commit 411d28f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/docs/changelog/1928.bugfix.rst b/docs/changelog/1928.bugfix.rst
@@ -0,0 +1 @@
+Avoid spawning new windows when doing seed package upgrades in the background on Windows - by :user:`gaborbernat`.
diff --git a/src/virtualenv/seed/wheels/periodic_update.py b/src/virtualenv/seed/wheels/periodic_update.py
@@ -22,7 +22,7 @@
 from virtualenv.app_data import AppDataDiskFolder
 from virtualenv.info import PY2
 from virtualenv.util.path import Path
-from virtualenv.util.subprocess import DETACHED_PROCESS, Popen
+from virtualenv.util.subprocess import CREATE_NO_WINDOW, DETACHED_PROCESS, Popen
 
 from ..wheels.embed import BUNDLE_SUPPORT
 from ..wheels.util import Wheel
@@ -186,7 +186,7 @@ def trigger_update(distribution, for_py_version, wheel, search_dirs, app_data, p
     pipe = None if debug else subprocess.PIPE
     kwargs = {"stdout": pipe, "stderr": pipe}
     if not debug and sys.platform == "win32":
-        kwargs["creationflags"] = DETACHED_PROCESS
+        kwargs["creationflags"] = DETACHED_PROCESS | CREATE_NO_WINDOW
     process = Popen(cmd, **kwargs)
     logging.info(
         "triggered periodic upgrade of %s%s (for python %s) via background process having PID %d",

diff --git a/src/virtualenv/util/subprocess/__init__.py b/src/virtualenv/util/subprocess/__init__.py
@@ -14,6 +14,7 @@
 
 
 DETACHED_PROCESS = 0x00000008
+CREATE_NO_WINDOW = 0x80000000
 
 
 def run_cmd(cmd):
@@ -33,4 +34,5 @@ def run_cmd(cmd):
     "Popen",
     "run_cmd",
     "DETACHED_PROCESS",
+    "CREATE_NO_WINDOW",
 )
diff --git a/tests/unit/seed/wheels/test_periodic_update.py b/tests/unit/seed/wheels/test_periodic_update.py
@@ -29,7 +29,7 @@
     trigger_update,
 )
 from virtualenv.util.path import Path
-from virtualenv.util.subprocess import DETACHED_PROCESS
+from virtualenv.util.subprocess import CREATE_NO_WINDOW, DETACHED_PROCESS
 
 
 @pytest.fixture(autouse=True)
@@ -224,7 +224,7 @@ def test_trigger_update_no_debug(for_py_version, session_app_data, tmp_path, moc
     assert args == ([sys.executable, "-c", cmd],)
     expected = {"stdout": subprocess.PIPE, "stderr": subprocess.PIPE}
     if sys.platform == "win32":
-        expected["creationflags"] = DETACHED_PROCESS
+        expected["creationflags"] = DETACHED_PROCESS | CREATE_NO_WINDOW
     assert kwargs == expected
     assert process.communicate.call_count == 0