Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twine upload hangs in Appveyor when the password is incorrect #224

Closed
mgedmin opened this issue Jan 12, 2017 · 4 comments
Closed

twine upload hangs in Appveyor when the password is incorrect #224

mgedmin opened this issue Jan 12, 2017 · 4 comments

Comments

@mgedmin
Copy link
Contributor

mgedmin commented Jan 12, 2017

We've changed the PyPI password for zope.wheelbuilder but forgot to update our appveyor.yml with the new password. Our Appveyor builds started timing out instead of failing with a clear error message, e.g.:

https://ci.appveyor.com/project/mgedmin/btrees/build/1.0.70/job/euva6qhjutoautfe

(the most hurtful thing is that Appveyor doesn't tell you the build timed out; it just passively-aggresively stops the job after an hour without saying anything at all).

#118 makes me suspect that Twine is asking for a password interactively, but the password prompt is not visible in Appveyor's build output.

Can we please have a --noninteractive option to turn this off?

@sigmavirus24
Copy link
Member

I'm confused as to why you think this is related to #118. As far as I know, so long as a password is provided, Twine will attempt to use it. We don't prompt if it turns out not to work. We prompt at the start of Twine if we can't find credentials and then we attempt to upload. The Repository and PackageFile classes (which are the only things involved in the upload at that point) don't know about how to prompt for credentials.

All of that said, a --noninteractive option is absolutely a valid request and would be perfectly sensible to add to Twine.

@mgedmin
Copy link
Contributor Author

mgedmin commented Jan 12, 2017

I'm confused as to why you think this is related to #118. As far as I know, so long as a password is provided, Twine will attempt to use it. We don't prompt if it turns out not to work.

I did not say "think", I said "suspect" 😉. I was unable to come up with any other explanations for the 60-minute timeout (enforced by Appveyor, not Twine) when an invalid PyPI password was provided. I guessed wrong.

Do you have any ideas?

@sigmavirus24
Copy link
Member

Looking over the source, we perform an upload after setting up credentials and if we're not skipping the package, then we check the response code in this function.

My best guess is that the sys.exit doesn't work the same way on Windows and that's why you're build times out. I have nothing other than suspicion though. Also, you would have seen a prompt if we had asked for credentials but you only see a message about Uploading.

Further, I'm wondering if anything else changed recently. twine upload dist/* should work, but it doesn't even attempt to upload any file. Perhaps this is an issue with clint on Windows?

@sigmavirus24
Copy link
Member

This has gone stale and there's little evidence that it's certainly an issue with twine.

anthrotype added a commit to harfbuzz/uharfbuzz that referenced this issue Jan 24, 2020
it looks like twine upload hangs in Appveyor when the password is incorrect...

pypa/twine#224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants