Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheel file regexp produces wrong attributes when filename contains dashes #145

Closed
pavel-paulau opened this issue Oct 26, 2015 · 1 comment
Closed

Wheel file regexp produces wrong attributes when filename contains dashes #145

pavel-paulau opened this issue Oct 26, 2015 · 1 comment
Assignees
@sigmavirus24
Milestone
1.6.4

Comments

@pavel-paulau
Copy link

An example of file name that breaks the regexp:

twine upload /tmp/le.0.0.0.dev20151025.YLl/dist.0.0.0.dev20151025/letsencrypt-nginx/letsencrypt_nginx-0.0.0.dev20151025-py2-none-any.whl

See letsencrypt bug for details.

You should either fix regular expression or use os.path.basename(). I can assist with the second approach.
sigmavirus24 added a commit to sigmavirus24/twine that referenced this issue Oct 26, 2015
@sigmavirus24
Use the basename of the wheel filename
e95247a 
Using the basename allows us to avoid problems with bizarrely non-standard
usage.

Closes pypa#145
@sigmavirus24 sigmavirus24 self-assigned this Oct 26, 2015
@sigmavirus24 sigmavirus24 mentioned this issue Oct 28, 2015
Merged
@sigmavirus24 sigmavirus24 modified the milestone: 1.6.4 Oct 28, 2015
@sigmavirus24
Copy link
Member

This was just fixed in 1.6.4 (released tonight). Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigmavirus24 sigmavirus24

Labels
None yet
Projects
None yet
Milestone
1.6.4
Development

No branches or pull requests
2 participants
@sigmavirus24 @pavel-paulau