-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
large file support #104
Comments
@dstufft isn't it true that PyPI has a limit on the file size so this is unnecessary? |
PyPI does have a limit, but people have internal PyPI's which don't have a limit. It seems silly to not support that when it's pretty easy to do I think. Just iterate over the file once to get the md5 hash and then seek back to the start and give requests an iterator? |
Except that even 1b14328 won't solve this because you need the |
Might be time to add a dependency on requests-toolbelt then? Or do you have an opposition to the feature in general? |
None at all. I had approached you a few months ago and you mentioned it not being a problem because of PyPI's limits. =P |
Oh, well I don't recall that :) I'm not actually good at this computer or project leading thing! |
No worries! That's why I pinged you about this. =D |
I added the requests-toolbelt dep to my PR. I think it's all good now if someone wants to double check it. |
It'd be great if twine could upload files larger than the system's memory. Currently, I don't think this is possible due to reading the entire file into memory
The text was updated successfully, but these errors were encountered: