Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large file support #104

Closed
a-tal opened this issue Apr 29, 2015 · 8 comments
Closed

large file support #104

a-tal opened this issue Apr 29, 2015 · 8 comments

Comments

@a-tal
Copy link
Contributor

a-tal commented Apr 29, 2015

It'd be great if twine could upload files larger than the system's memory. Currently, I don't think this is possible due to reading the entire file into memory

@sigmavirus24
Copy link
Member

@dstufft isn't it true that PyPI has a limit on the file size so this is unnecessary?

a-tal added a commit to a-tal/twine that referenced this issue Apr 29, 2015
@dstufft
Copy link
Member

dstufft commented Apr 29, 2015

PyPI does have a limit, but people have internal PyPI's which don't have a limit. It seems silly to not support that when it's pretty easy to do I think. Just iterate over the file once to get the md5 hash and then seek back to the start and give requests an iterator?

@sigmavirus24
Copy link
Member

Except that even 1b14328 won't solve this because you need the MultipartEncoder from the requests-toolbelt. It's the only way to stream a multipart/form-data upload (which is what twine is currently performing).

@dstufft
Copy link
Member

dstufft commented Apr 29, 2015

Might be time to add a dependency on requests-toolbelt then? Or do you have an opposition to the feature in general?

@sigmavirus24
Copy link
Member

None at all. I had approached you a few months ago and you mentioned it not being a problem because of PyPI's limits. =P

@dstufft
Copy link
Member

dstufft commented Apr 29, 2015

Oh, well I don't recall that :) I'm not actually good at this computer or project leading thing!

@sigmavirus24
Copy link
Member

No worries! That's why I pinged you about this. =D

@a-tal
Copy link
Contributor Author

a-tal commented May 1, 2015

I added the requests-toolbelt dep to my PR. I think it's all good now if someone wants to double check it.

a-tal added a commit to a-tal/twine that referenced this issue May 1, 2015
a-tal added a commit to a-tal/twine that referenced this issue May 1, 2015
sigmavirus24 added a commit that referenced this issue May 1, 2015
@a-tal a-tal closed this as completed May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants