-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LICENSE file for expectant auditors #730
Conversation
Ah, forgot the changelog entry. |
7d395b7
to
448d925
Compare
@@ -6,6 +6,8 @@ v25.1.6 | |||
------- | |||
|
|||
* #725 | |||
* #612 via #730: Add a LICENSE file which neds to be provided by the terms of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this entry should go in a new section for v25.2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done & done.
The classifier in setup.py should be enough for most auditors, but some have automated tooling that checks for LICENSE files and reads those. This helps all auditors (downstream redistributors and users) who can not just rely on the classifier. Related to pypa#612
448d925
to
8383954
Compare
Do you think there is any value to having a |
@jakirkham not really? Almost every project I've ever seen has had the license file sans |
Yeah, we can both dig up numerous examples either way both inside and outside of the Python ecosystem. I don't think it really matters and this (merged) pull request certainly isn't the place for a discussion of this type (whether or not to put .txt at the end of a LICENSE file name because some operating systems do weird things in an attempt to be smart). |
The classifier in setup.py should be enough for most auditors, but some
have automated tooling that checks for LICENSE files and reads those.
This helps all auditors (downstream redistributors and users) who can
not just rely on the classifier.
Related to #612