Update pyright configs comments #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Update-pyright-configs
branch
2 times, most recently
from
b05f8aa to
2667e5c
Compare
Avasam
force-pushed
the
Update-pyright-configs
branch
from
2667e5c to
df12ccb
Compare
Avasam
commented
Aug 30, 2024
Comment on lines
+4
to
+11
| // Avoid scanning Python files in generated folders | ||
| "build", | ||
| ".tox", | ||
| ".eggs", | ||
| "**/_vendor", // Vendored | ||
| "setuptools/_distutils", // Vendored | ||
| "setuptools/config/_validate_pyproject/**", // Auto-generated | ||
| "setuptools/config/_validate_pyproject/**", | ||
| // These are vendored | ||
| "**/_vendor", | ||
| "setuptools/_distutils", |
There was a problem hiding this comment.
Same comments as in mypy.ini
Avasam
commented
Aug 30, 2024
| // FIXME: A handful of reportOperatorIssue spread throughout the codebase | ||
| "reportOperatorIssue": "warning", | ||
| // Deferred initialization (initialize_options/finalize_options) causes many "potentially None" issues | ||
| // TODO: Fix with type-guards or by changing how it's initialized | ||
| "reportArgumentType": "warning", // A lot of these are caused by jaraco.path.build's spec argument not being a Mapping https://github.com/jaraco/jaraco.path/pull/3 |
There was a problem hiding this comment.
This has been fixed upstream, so the comment doesn't apply anymore and those reportArgumentType left are of setuptool's own making.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Config-only changes to make comments more up to date
Pull Request Checklist
newsfragments/. (not user facing)(See documentation for details)