Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is a follow up of the discussion on #4457 (review).
Since Python 3.7,
dict
preserve insertion order.This means that
dict
is a capable implementation of an ordered set,despite the method names not lining up completely.
We can effectively use
dict
to obtain the same functionality that would be implemented byordered_set
and therefore we can remove the extra dependency.Closes
Pull Request Checklist
newsfragments/
.(See documentation for details)
Optionally, we could have something like
But that would be mostly cosmetic, since we can simply use the
dict
methods directly and obtain the same effects...