-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove .gitignore #4453
Remove .gitignore #4453
Conversation
I personally have two concerns in flat-out removing the .gitignore file:
Other than that (which are more documentation concerns), I think this approach is fine as it works for pypa / jaraco repositories/ecosystem, and contributors should have a few documented and easily accessible options of dealing with it the way that suits them best. |
That's fair, and thanks for sharing. I realize it's "for a single project", but I observe you are already contributing to at least two projects affected by this issue (setuptools and distutils). I suspect, however, that you may also have interest in supporting some of setuptools' dependencies, several of which also follow the skeleton philosophy. Moreover, the philosophy extends beyond skeleton-based projects, as it adds value for any new project or any project that's underconfigured for ignores.
The git ignore docs mention Git doesn't provide a good config scope for this purpose. They have That's why the motivations are documented (and linked from the README by way of the skeleton badge, albeit subtle).
Good point. I'm always willing to improve the docs. I think using
I have only once run into a situation where the cross-repo concerns caused problems (pypa/build#518) and it was easily worked-around by overriding locally. In a situation where a project is specifically looking to track a file that's commonly ignored, I'd consider explicitly including in the
While I agree it would be nice provide guidance where the user would stumble on it easily, it also means adding yet another static file to the boilerplate. Moreover, it implies that there should be more comments across each and every file in the skeleton pointing back to the skeleton guidance (e.g. Nevertheless, I am tempted by the idea of adding a link in the For now, I'm unconvinced, but if the pressure increases, I'll likely capitulate and expand the guidance (in skeleton, not here). I believe updating the docs and providing the per-checkout escape hatch should address the concerns and now I'm a lot more emboldened to proceed with this PR as proposed. @Avasam Do you concur? |
At the end of the day, maintainers are the one that would have to deal with any increased contributor guidance/support, not I. And as you said, the door is open to increase documented guidance if you feel the need for it. So the ball's really all in your camp there :) We seem to agree that the global gitignore is a good way to tackle a shared concern across multiple repos, and works for
So do I. Thanks for this discussion! |
@abravalheri I'm merging now, but let me know if this causes you any consternation and the updated guidance doesn't provide a satisfactory solution. |
I'd like to add that the missing .gitignore makes the file search in vscode hard to use as it includes all .pyc files too. |
@lazka in your user configs, or the project's "search.exclude": {
"*.pyc": true,
}, As a more general comment, it does mean any tool that was using |
The presence of a
.gitignore
file only contradicts the documented strategy. With this file removed, even after running tests, git reports "working tree clean" in my environment. There's no need for the.gitignore
.Users have a couple of options for ignoring artifacts as documented in that (now updated) strategy: