Rename _InstallerTypeT and mark type aliases with TypeAlias
#4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
_InstallerTypeT and mark type aliases with TypeAlias
Avasam
force-pushed
the
Rename-_InstallerTypeT
branch
from
2a024ca to
fee43d2
Compare
2 tasks
Avasam
force-pushed
the
Rename-_InstallerTypeT
branch
from
fee43d2 to
08c3b82
Compare
abravalheri
reviewed
Aug 8, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Noticed in python/typeshed#12215
According to https://github.com/PyCQA/flake8-pyi/blob/main/ERRORCODES.md#Y043 , that was a bad name to have as it implies a TypeVar. I've renamed the alias to a more fitting
_StrictInstallerType(alternatively:_GenericInstallerType)This would've been caught by https://docs.astral.sh/ruff/rules/t-suffixed-type-alias/ if it was explicitly marked as a type alias.
Explicitly marked all type aliases I could easily find with
TypeAlias(available in Python 3.10, backported totyping_extensions).Pull Request Checklist
newsfragments/. (not user facing)(See documentation for details)