Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to typing.cast with better type narrowing and definitions #4375

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented May 21, 2024

Summary of changes

Remove calls to typing.cast with better type narrowing and definitions. Better assurance of actual type.
xref for validate-pyproject: abravalheri/validate-pyproject#176

Pull Request Checklist

  • Changes have tests (some type-checking, note sure if there's runtime tests for these)
  • News fragment added in newsfragments/. (not user facing)
    (See documentation for details)

@Avasam Avasam changed the title Remove calls to typing.cast with better type narrowing Remove calls to typing.cast with better type narrowing and definitions May 21, 2024
@Avasam Avasam force-pushed the reduce-redundant-casts branch 2 times, most recently from 673d517 to 25a71b6 Compare May 21, 2024 18:14
Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Avasam.

setuptools/config/_apply_pyprojecttoml.py Outdated Show resolved Hide resolved
setuptools/config/_apply_pyprojecttoml.py Show resolved Hide resolved
setuptools/config/_apply_pyprojecttoml.py Outdated Show resolved Hide resolved
setuptools/dist.py Outdated Show resolved Hide resolved
setuptools/dist.py Outdated Show resolved Hide resolved
@Avasam Avasam force-pushed the reduce-redundant-casts branch from f3bb2d3 to 6c4d2ca Compare June 17, 2024 17:44
@abravalheri abravalheri merged commit 2299319 into pypa:main Jun 17, 2024
22 checks passed
@Avasam Avasam deleted the reduce-redundant-casts branch June 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants