Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_resources: Remove unused and shadowed variables #4260

Merged

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Mar 6, 2024

Summary of changes

Extracted from https://github.com/pypa/setuptools/pull/4242/files#r1513644506

Pull Request Checklist

  • Changes have tests (existing tests should pass, this should all be dead code)
  • News fragment added in newsfragments/.
    (See documentation for details)

@Avasam Avasam force-pushed the pkg_resources-remove-unused-and-shadowed branch from 745f3c7 to ba09176 Compare March 6, 2024 17:35
@abravalheri
Copy link
Contributor

abravalheri commented Mar 6, 2024

Thanks @Avasam, I think we can merge this one as soon as the CI passes.


For future readers wondering if the PR would change the exposed API, we have discussed this in #4242 (comment), and the conclusion is that this PR should be safe ( _initialize_master_working_set is already doing all the work).

@abravalheri abravalheri merged commit 9b081af into pypa:main Mar 6, 2024
23 checks passed
@Avasam Avasam deleted the pkg_resources-remove-unused-and-shadowed branch March 6, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants