Fix setuptools.depends:get_module_constant() on Python 3.13.0a1 #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't hardcode opcode numbers, look them up instead. Fixes pypa#4090
abravalheri
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Thank you very much @hroncok. Probably we can add this to the next release of setuptools (which I am planning for some time around the beginning of the month, but may change if Jason has a different idea).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Don't hardcode opcode numbers, look them up instead.
Fixes #4090
Pull Request Checklist
newsfragments/.(See documentation for details)