Merge changes from distutils 2def21c5d74fdd #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils.sysconfig provides various functions already present in the stdlib sysconfig module. Reusing the stdlib versions has the advantage that it is in control of the Python distributor/packager and distutils doesn't have to deal with platform details. This tries to start the transition using the simple get_config_h_filename() for starters by forwarding calls to the stdlib in case Python is considered to be installed.
The only difference is the argument name change
sysconfig: use get_config_h_filename() from the stdlib
See python/cpython#28299 loadTestsFromTestCase() is available since Python 2.7 at least.
I added a test for sysconfig.parse_config_h() in 9d0b8cd which assumed pyconfig.h always has some macros defined and checked that the result was non-empty. On Ubuntu 22.04 the pyconfig.h is just a shim, including various platform specific configs and not defining anything directly. This changes the test to not assume anything about the output of parse_config_h() instead.
Don't assume a "python" is in PATH. Fixes this test when run from an uninstalled Python at least.
Instead of guessing the filename just refer to the stdlib. This also removes the "_makefile_tmpl" hook added in #16, but 1) It was never implemented by the distro requesting it from what I can see: https://github.com/NetBSD/pkgsrc/blob/586097714897b1b4d4a9/devel/py-setuptools/Makefile#L28 2) The stdlib version should return a proper result as it is patched by the distro requesting the change: https://github.com/NetBSD/pkgsrc/blob/6efa5763ec447864a7d4/lang/python38/patches/patch-Lib_sysconfig.py Also adds a small test checking that the file exists on Unix platforms
…ump to Python 3.10, matching jaraco/skeleton and pypa/setuptools approaches.
…alenv can't install without it. Ref man-group/pytest-plugins#190
tests: use sys.executable instead of hardcoding "python"
tests: fix tests on Ubuntu 22.04
tests: use loadTestsFromTestCase() instead of the deprecated makeSuite()
sysconfig: use get_makefile_filename() from stdlib sysconfig
matthiasdiener
added a commit
to illinois-ceesd/emirge
that referenced
this pull request
Feb 7, 2022
This reverts commit cae95cf. The underlying setuptools bug has been fixed: pypa/setuptools#2987
matthiasdiener
added a commit
to illinois-ceesd/mirgecom
that referenced
this pull request
Feb 8, 2022
…ing distutils (#585)" This reverts commit 6ae2890. The underlying setuptools bug has been fixed: pypa/setuptools#2987
matthiasdiener
added a commit
to illinois-ceesd/mirgecom
that referenced
this pull request
Feb 9, 2022
…ing distutils (#585)" (#604) This reverts commit 6ae2890. The underlying setuptools bug has been fixed: pypa/setuptools#2987
matthiasdiener
added a commit
to illinois-ceesd/emirge
that referenced
this pull request
Feb 9, 2022
This reverts commit cae95cf. The underlying setuptools bug has been fixed: pypa/setuptools#2987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes
Pull Request Checklist
changelog.d/.(See documentation for details)