Fix 2880, 2881 - Avoid depdencies with URLs in setup.cfg #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyPI does not accept this kind of dependencies. An alternative is to overwrite the dependency in tox.ini
|
Looks good. Thanks! |
jaraco
approved these changes
Nov 14, 2021
|
By looking at the CI logs, we can confirm that
|
abravalheri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seems that #2865 might have accidentally introduced a kind of dependency that is not accepted by PyPi:
[options.extras_require] testing = ... - pytest-virtualenv>=1.2.7 + pytest-virtualenv @ git+https://github.com/jaraco/pytest-plugins@distutils-deprecated#subdirectory=pytest-virtualenvin
setup.cfg.PyPI forbids uploading packages with dependencies outside of PyPI (via URLs specs).
Summary of changes
depsin tox.iniCloses #2880
Closes #2881
Pull Request Checklist
changelog.d/.(See documentation for details)