Added Visual Studio Express 2017 support #2663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added Visual Studio Express 2017 detection to
setuptools/msvc.py
.Some details
Setuptools cannot detect Visual Studio Express 2017 automatically for now.
It's detecting Visual Studio using this command:
vswhere -latest -prerelease -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath -products *
This prints nothing because component ID
Microsoft.VisualStudio.Component.VC.Tools.x86.x64
is missing in VS Express 2017https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-express?view=vs-2017
So, it should include VS Express explicitly using this command:
vswhere -latest -prerelease -requiresAny -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -requires Microsoft.VisualStudio.Workload.WDExpress -property installationPath -products *
Or, detect ARM compiler using component ID
Microsoft.VisualStudio.Component.VC.Tools.ARM
, andMicrosoft.VisualStudio.Component.VC.Tools.ARM64
.Detecting ARM compiler(eb27045) might be more good solution because setuptools supports ARM. But there are some corner case to deal with. (It seems like ARM compiler can be installed without buildtools.)
So, I just included VS Express workload ID.
Pull Request Checklist
changelog.d/
.(See documentation for details)